Skip to content

chore(operations-gen): delete unused testdata#987

Merged
graham-chainlink merged 1 commit into
mainfrom
ggoh/chore-unused-test-data
May 19, 2026
Merged

chore(operations-gen): delete unused testdata#987
graham-chainlink merged 1 commit into
mainfrom
ggoh/chore-unused-test-data

Conversation

@graham-chainlink

Copy link
Copy Markdown
Collaborator

We no longer uses the abi and bin files in the test data, we now used the generated bindings instead.

We no longer uses the abi and bin files in the test data, we now used the generated bindings instead.
@changeset-bot

changeset-bot Bot commented May 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: fd436c3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graham-chainlink graham-chainlink marked this pull request as ready for review May 19, 2026 04:56
@graham-chainlink graham-chainlink requested a review from a team as a code owner May 19, 2026 04:56
Copilot AI review requested due to automatic review settings May 19, 2026 04:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes obsolete EVM ABI/bytecode fixture files from tools/operations-gen/testdata now that operations-gen tests and configs rely on abigen-generated Go bindings (gobindings) instead.

Changes:

  • Delete unused EVM abi/ and bytecode/ fixture files for LinkToken and ManyChainMultiSig.
  • Update the E2E golden test comment to reflect the switch from ABI/bytecode fixtures to gobindings.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tools/operations-gen/testdata/evm/bytecode/v1_0_0/many_chain_multi_sig.bin Removed unused bytecode fixture.
tools/operations-gen/testdata/evm/bytecode/v1_0_0/link_token.bin Removed unused bytecode fixture.
tools/operations-gen/testdata/evm/abi/v1_0_0/many_chain_multi_sig.json Removed unused ABI fixture.
tools/operations-gen/testdata/evm/abi/v1_0_0/link_token.json Removed unused ABI fixture.
tools/operations-gen/internal/families/evm/evm_golden_test.go Updated test comment to reference gobindings fixtures.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cl-sonarqube-production

Copy link
Copy Markdown

@graham-chainlink graham-chainlink added this pull request to the merge queue May 19, 2026
Merged via the queue into main with commit 4562a68 May 19, 2026
30 checks passed
@graham-chainlink graham-chainlink deleted the ggoh/chore-unused-test-data branch May 19, 2026 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants